Union type int|false is converted to type int|bool when using template.

[vdauchy]

Bug report

Union type int|false is converted to type int|bool when using template.

Code snippet that reproduces the problem

https://phpstan.org/r/fd175ccc-e72b-4b2c-9adf-008f02e66533

Expected output

No error shall be detected.

Did PHPStan help you today? Did it make you happy in any way?

Hi, thanks for your work, I'm having a relaxing time solving issues in my libs <3

[staabm]

the problem happens because of the templated closure involved.

without a template type it works as expected:
https://phpstan.org/r/b0babc02-b847-4c0c-819c-420f16f6582f

@rvanvelzen I think you are the expert in this area

[rvanvelzen]

This is due to template type generalisation. See phpstan/phpstan-src#1206 for more info.

[ondrejmirtes]

Last night I came up with the idea that we mostly shouldn't generalize the generic type variables, except when they're in object generics, like Foo<int>.

Here's the resulting PR: phpstan/phpstan-src#2818

We can't do this for objects, because I want new Collection([1, 2, 3]) to become Collection<int>. This could be improved in the future thanks to this suggestion: #6732 (comment) (but it's pretty complex to implement so for now it has to wait).

The new behaviour now only applies to bleeding edge (https://phpstan.org/blog/what-is-bleeding-edge) so definitely enable it to get the taste of the future 👍

[vdauchy]

I received the notification for your PR, thanks for all of this 🥳

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.