Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue errors when implementing deprecated Serializable interface without serialization magic methods #7482

Closed
bburnichon opened this issue Jun 15, 2022 · 1 comment · Fixed by phpstan/phpstan-src#1711

Comments

@bburnichon
Copy link

Feature request

Add an issue at level 0 for classes intended to be compatible with php >8.1 that implements deprecated Serializable interface but have no serialization magic methods.

Discussed in #7480

Originally posted by bburnichon June 15, 2022
Hi there,

I am currently working on making codebase compatible with php 8.1, I am looking for a rule to detect classes implementing Serializable but not implementing __serialize and __unserialize methods which appeared in PHP 7.4.

Do you know whether this was already implemented?

Thanks in advance for your support.

Did PHPStan help you today? Did it make you happy in any way?

I am really satisfied when my php code passes phpstan at max level. So many bugs avoided right before making their way to production.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants