String accessory types are normalized to string types when used with generics

[mad-briller]

Bug report

This issue exists on 1.7.0

When using generics with string accessory types, the accessory types are lost:

Code snippet that reproduces the problem

https://phpstan.org/r/784f01e9-f48e-4bcb-89dc-a49cacb2c34e

Expected output

Expected to see array<non-empty-string, mixed> in the \PHPStan\dumpType output.

Did PHPStan help you today? Did it make you happy in any way?

PHPStan helps me everyday! congrats on the 1.7.0 release with fully static analysis, great work

[ondrejmirtes]

Last night I came up with the idea that we mostly shouldn't generalize the generic type variables, except when they're in object generics, like Foo<int>.

Here's the resulting PR: phpstan/phpstan-src#2818

We can't do this for objects, because I want new Collection([1, 2, 3]) to become Collection<int>. This could be improved in the future thanks to this suggestion: #6732 (comment) (but it's pretty complex to implement so for now it has to wait).

The new behaviour now only applies to bleeding edge (https://phpstan.org/blog/what-is-bleeding-edge) so definitely enable it to get the taste of the future 👍

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.