preg_match's referenced matches not considered updated

[ondrejmirtes]

Discussed in #5361

^{Originally posted by hollodotme July 22, 2021}

Code

<?php declare(strict_types = 1);

$matches = [];
$pattern = '#^C\s+(?<productId>\d+)$#i';
$subject = 'C 1234567890';

$found = (bool)preg_match( $pattern, $subject, $matches ) && isset( $matches['productId'] );

PHPStan Error

LINE   ERROR
-------------------------------------
7      Result of && is always false.

See: https://phpstan.org/r/dc55b6b9-5285-4b3c-895f-bb036dd1e2d5

IMO this is a false positive as the second condition isset($matches['productId']) is true after evaluation of the preg_match function.

The $matches array was changed by preg_match() via reference.

[ondrejmirtes]

Looks like PHPStan is a bit confused about already existing $matches variable, without it it works: https://phpstan.org/r/ae249e12-2326-494c-968c-316e503e9768

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+8: Result of && is always false.

Full report

Line	Error
8	Result of && is always false.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.