usort changes type of passed variable, phpstan not picking it up

[d-claassen]

Bug report

usort accepts a passed-by-reference array of array<array-key, T> as first argument, but will always transform that argument into array<int, T>. This is also noted in the php docs:

Note: This function assigns new keys to the elements in array. It will remove any existing keys that may have been assigned, rather than just reordering the keys.

So when giving usort an array of array<string, T> the passed array becomes array<int, T>. PHPStan however does not pick this up. I looked at updating the functionMap.php file, but I did not see how this can be documented in the current format. If I missed something I'd be happy to provide a pull request with an update to it!

Code snippet that reproduces the problem

The snippet that reproduces can be found here:
https://phpstan.org/r/cd33a591-5f93-4df3-b878-49af85ef487e

I've also confirmed the behavior as described in the php docs with the same code in this 3v4l.org test.

Expected output

I would've expected PHPStan not to return an error. Both Psalm and Phan do not return any error about this.

[ondrejmirtes]

Hi, never heard about this, didn't know that usort changes these keys. This would have to be implemented somewhere around these lines: https://github.com/phpstan/phpstan-src/blob/b07b33d2ff9b888b8c7baa1ff64d4aa71624cf99/src/Analyser/NodeScopeResolver.php#L1384-L1435

[MidnightDesign]

Small correction: the output type should be list<T>, not just array<int, T>. https://3v4l.org/P5COJ

[ondrejmirtes]

Fixed: phpstan/phpstan-src#2891

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.