Allow referencing env variables in project config

[marcospassos]

For CI environment, it would be nice to have an option to specify the temporary directory when running PHPStan. Currently, it can only be configured through the configuration file.

[ondrejmirtes]

Yes, and why is that not sufficient? :)

[marcospassos]

Because the CI server requires a specific cache directory.

[ondrejmirtes]

You can make a local phpstan.neon file and put the versioned one into includes section. Like I do for example here: https://github.com/phpstan/phpstan/blob/master/conf/config.level2.neon#L1-L2

It's a pretty common practice that allows you to override project configuration with local machine's specific settings.

[marcospassos]

@ondrejmirtes the path to the cache is acessed via an environment variable.

[ondrejmirtes]

We could change this feature request to "make environment variables accessible in the neon config".

[marcospassos]

it's ok for me, but why passing it as an argument is a problem?

[ondrejmirtes]

I don't want to overload it with too many options, I allowed the paths and level to be in both CLI options and in the neon config with screeching teeth :) I don't want to do it for everything.

[marcospassos]

I understand your point, but allowing it as an option would be much more flexible IMHO.

[ondrejmirtes]

I think that my suggestion will make everything much more flexible :) BTW right now you could generate .neon config based on your env variable and use that. I do a similar thing right here: https://github.com/phpstan/phpstan/blob/master/build.xml#L193-L223

[tbmatuka]

@ondrejmirtes I figured I could do a PR for this because I might need it, but I do have a couple of questions:

1. Do you have any preference for how the variables should be named? Do you want to namespace them like env: or something like that?
2. It looks to me like the only thing needed to make this work is to add the variables as parameters in DependencyInjection\LoaderFactory. Is that it, or am I missing anything?

[ondrejmirtes]

@tbmatuka Adding it to LoaderFactory would help you to only reference it in includes section. To be able to reference them in parameters section, you should add it to ContainerFactory::create() - there's call to $configurator->addParameters where it should be added. The environment variables should be in env array, so they can be referenced with %env.foo%.

[ondrejmirtes]

This is now as simple as phpstan/phpstan-src#2559 but it's blocked by nette/di#291.

Most of the work was unblocked by phpstan/phpstan-src#2558

[ondrejmirtes]

Implemented: phpstan/phpstan-src#2559

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.