SimpleXMLELement::addChild return type is incorrect.

[DaveLiddament]

Bug report

Looking at the PHP docs SimpleXMLElement::addChild can return null, however PHPStan is reporting that addChild can never return null

Code snippet that reproduces the problem

https://phpstan.org/r/8b9cd1df-ed7c-48e0-916a-d8e127e50257

Expected output

I'd expect no issues reported in the code snippet.

Is the fix as simple as updating this line in functionMap?

- 'SimpleXMLElement::addChild' => ['static', 'name'=>'string', 'value='=>'string|null', 'ns='=>'string|null'],
+ 'SimpleXMLElement::addChild' => ['static|null', 'name'=>'string', 'value='=>'string|null', 'ns='=>'string|null'],

Did PHPStan help you today? Did it make you happy in any way?

PHPStan helps me every day. And I've also got to speak at a few conferences off the back of your tool!

[phpstan-bot]

@DaveLiddament After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
-6: Strict comparison using !== between SimpleXMLElement and null will always evaluate to true.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src#2808

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.