Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Why is the composer.json file removed from the image? #345

Closed
RubenAtPA opened this issue Aug 23, 2021 · 3 comments
Closed

[question] Why is the composer.json file removed from the image? #345

RubenAtPA opened this issue Aug 23, 2021 · 3 comments
Assignees
Labels

Comments

@RubenAtPA
Copy link

When trying to add a custom authentication plugin we need to be able to add some composer packages. Now I noticed that the composer.json file is purposely removed from the image. This leaves the question: why? This makes it extra difficult to do some custom changes to this image.

@RubenAtPA RubenAtPA changed the title Question: Why is the composer.json file removed from the image [question] Why is the composer.json file removed from the image Aug 23, 2021
@RubenAtPA RubenAtPA changed the title [question] Why is the composer.json file removed from the image [question] Why is the composer.json file removed from the image? Aug 23, 2021
@williamdes
Copy link
Member

williamdes commented Aug 23, 2021

Yes it seems removed, I am not sure why
https://github.com/phpmyadmin/docker/blob/master/Dockerfile-debian.template#L111

I found it was done in 50f822a to fix #78

Anyway, I will revert for composer.json and adjust the line.
cc @emanuelb

@williamdes williamdes self-assigned this Aug 23, 2021
@williamdes williamdes added the bug label Aug 23, 2021
@RubenAtPA
Copy link
Author

@williamdes Thanks for picking it up so quickly. Any idea when this change will be pushed in a new image at dockerhub?

@williamdes
Copy link
Member

@williamdes Thanks for picking it up so quickly. Any idea when this change will be pushed in a new image at dockerhub?

Most probably on next phpMyAdmin release
Maybe in a big bunch of days
You can subscribe to releases on this page after the 🌟 star button ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants