New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trace of the error when debug verbosity #1023
Add trace of the error when debug verbosity #1023
Conversation
431f25c
to
a15115e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
============================================
+ Coverage 89.50% 92.37% +2.87%
- Complexity 1200 1215 +15
============================================
Files 109 110 +1
Lines 3086 3331 +245
============================================
+ Hits 2762 3077 +315
+ Misses 324 254 -70
☔ View full report in Codecov by Sentry. |
6bf8d5b
to
e7775e9
Compare
@ravage84 Would you mind to update the required jobs? Renaming And extend range up to PHP version 8.3? |
e7775e9
to
2508d8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a side note i think assert regex was removed in recent version, but i might be remembering wrong.
Yes, but the new method name is not available in the super-old version we need to use to support PHP 5.3 😢 Even with the "higher" version, it does not show deprecation notice: |
Hm the other main project I'm working with builds natively for 1987 Amiga and 2022 Android, I'm starting to question my life decisions. |
Done. Should be active with the next builds. |
Co-authored-by: Marc Würth <ravage@bluewin.ch>
Co-authored-by: Marc Würth <ravage@bluewin.ch>
Type: feature
Breaking change: no
--error-file
- send errors (other than reported violations) output to a file; default toSTDERR
Allow to record error in a file (consistently with what is possible for report now with
--report-file
)Handle deprecation and error consistently. Both inside
Command
instead of error inCommand
and deprecation directly output byCommandLineOptions
(which shouldn't be the responsibility ofCommandLineOptions
IMO).Show error stack trace when using debug verbosity.
Add few tests for
Command
andCommandLineOptions
Run tests coverage with PHP 8.2 and xdebug (we had phpdbg for performance reasons, but this is no longer an issue with xdebug 3, also phpdbg struggles to properly mark coverage in
switch
statements, so let's move back to xdebug and align workflows with PDepend ones)