fix Psalm annotations for traits and their usages #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that I have problems with validating such code via psalm:
It's because
__construct()
of theVector
is described inGenericSequence
trait which is typed incorrectly: generic types are only defined in interfaces, but not in traits. This PR fixes that, adds@template-use
annotations to trait clients, and also removes meaningless@inheritDoc
annotation fromGenericSequence
, which by the way was not used inGenericCollection
(traits have no inheritance tree).