Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals rendered in sticky LiveViews are broken after live navigation #3658

Closed
jtormey opened this issue Feb 1, 2025 · 0 comments · Fixed by #3659
Closed

Modals rendered in sticky LiveViews are broken after live navigation #3658

jtormey opened this issue Feb 1, 2025 · 0 comments · Fixed by #3659

Comments

@jtormey
Copy link

jtormey commented Feb 1, 2025

Environment

  • Elixir version (elixir -v): 1.17.3
  • Phoenix version (mix deps): 1.7.19
  • Phoenix LiveView version (mix deps): 1.0.3
  • Operating system: MacOS
  • Browsers you attempted to reproduce this bug on (the more the merrier): Google Chrome
  • Does the problem persist after removing "assets/node_modules" and trying again? Yes/no: Yes

Actual behavior

Modals rendered in a sticky LiveView do not reveal on click after a live navigation.

Expected behavior

Modal behavior should be the same in normal LiveViews and sticky LiveViews, before and after live navigation.

Recreation here: jtormey/sticky_lv_broken_modal@a08f418

549be9308e389a7768df2f6af11e9a36.mp4
SteffenDE added a commit that referenced this issue Feb 1, 2025
Fixes #3656
Fixes #3658
SteffenDE added a commit that referenced this issue Feb 1, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixes #3656
Fixes #3658
SteffenDE added a commit that referenced this issue Feb 1, 2025
Fixes #3656
Fixes #3658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant