Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't overuse requestAnimationFrame #3657

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

SteffenDE
Copy link
Collaborator

@SteffenDE SteffenDE commented Jan 31, 2025

This ensures that JS.focus works on iOS.

Fixes: #3563
Relates to: #1826

Verified

This commit was signed with the committer’s verified signature.
killagu killa
This ensures that JS.focus works on iOS.

Fixes: #3563
@SteffenDE
Copy link
Collaborator Author

@jonatanklosko you originally reported #1826. Could you please check if this reintroduces an issue for livebook?

{:phoenix_live_view, github: "phoenixframework/phoenix_live_view", branch: "sd-requestAnimationFrame-assets", override: true}

includes the built assets.

@jonatanklosko
Copy link
Contributor

@SteffenDE it appears to be working as expected, though we actually changed the Livebook menu from #1826 to use an overlay, so regression probably wouldn't be noticeable. That said, I checked the example I posted on the issue and it also works as expected, so I think we are good :)

@SteffenDE SteffenDE marked this pull request as ready for review February 1, 2025 19:37
@SteffenDE SteffenDE merged commit dd5db84 into main Feb 1, 2025
16 checks passed
@SteffenDE SteffenDE deleted the sd-requestAnimationFrame branch February 1, 2025 19:37
SteffenDE added a commit that referenced this pull request Feb 1, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
This ensures that JS.focus works on iOS.

Fixes: #3563
SteffenDE added a commit that referenced this pull request Feb 23, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
This reverts commit 485c349.

We need to revert because this changes the behavior of JS.show |> JS.show
where the second JS show relied on the first one not being applied yet.

We will keep the change in 1.1 and document it.

This means that #3563 will
be broken again on 1.0.5 :(
SteffenDE added a commit that referenced this pull request Feb 26, 2025

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Fixes #3691.
Fixes #3675.
Fixes #3563.
Relates to: #3657
Relates to: f06877a
SteffenDE added a commit that referenced this pull request Feb 26, 2025

Partially verified

This commit is signed with the committer’s verified signature.
ruyadorno’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Fixes #3691.
Fixes #3675.
Fixes #3563.
Relates to: #3657
Relates to: f06877a
SteffenDE added a commit that referenced this pull request Feb 27, 2025

Partially verified

This commit is signed with the committer’s verified signature.
ruyadorno’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
* ensure JS.show/hide/toggle work as before, fix focus

Fixes #3691.
Fixes #3675.
Fixes #3563.
Relates to: #3657
Relates to: f06877a

* try to clarify comments
SteffenDE added a commit that referenced this pull request Feb 27, 2025
* ensure JS.show/hide/toggle work as before, fix focus

Fixes #3691.
Fixes #3675.
Fixes #3563.
Relates to: #3657
Relates to: f06877a

* try to clarify comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS.focus does not work on iOS for text fields
2 participants