Optimize maybeHideFeedback for initial page render #2953
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR optimizes the initial page render for pages containing thousands of inputs; instead of calling `DOM.all` for each input, we build a selector to match all inputs and query the DOM. From my testing, this has reduced the page rendering time from over 30 seconds to 4-5 seconds.
chrismccord
reviewed
Dec 18, 2023
assets/js/phoenix_live_view/dom.js
Outdated
| if(!(this.private(input, PHX_HAS_FOCUSED) || this.private(input, PHX_HAS_SUBMITTED))){ | ||
| let feedbacks = [input.name] | ||
| if(input.name.endsWith("[]")){ feedbacks.push(input.name.slice(0, -2)) } | ||
| selector = feedbacks.map(f => `[${phxFeedbackFor}="${f}"]`).join(", ") |
There was a problem hiding this comment.
this discards the previous selector. Instead you can accumulate the feedbacks, then join the into a selector on the outside of the forEach
There was a problem hiding this comment.
Thanks, I've pushed a commit that leverages the feedback for accumulation. I still see improvements on pages containing thousands of inputs; I need a better understanding of LiveView's JS and Morphdom to determine if there is a better way to improve the initial page render for pages that stream thousands of inputs.
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the initial page render for pages containing thousands of inputs; instead of calling
DOM.allfor each input, we build a selector to match all inputs and query the DOM.From my testing, this has reduced the page rendering time from over 30 seconds to 4-5 seconds.