Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap click started on mousedown rather than click. #2554

Closed
wants to merge 4 commits into from
Closed

Trap click started on mousedown rather than click. #2554

wants to merge 4 commits into from

Conversation

jbosse
Copy link

@jbosse jbosse commented Mar 24, 2023

The click event isn't raised until mouseup.

This fixes #1920 which was still broken as shown below

Reproduce issue:
reproduce

Fixed:
fix

jbosse and others added 3 commits March 24, 2023 11:33
The click event isn't raised until mouseup.
Trap click started on mousedown rather than click.
@jbosse
Copy link
Author

jbosse commented Apr 11, 2023

😢

@chrismccord
Copy link
Member

Hang tight on this one is on my list :)
I need to do some extensive testing as it could cause races elsewhere with the way we perform click-away. Thanks!

@jbosse
Copy link
Author

jbosse commented Oct 5, 2023

Hang tight on this one is on my list :)
I need to do some extensive testing as it could cause races elsewhere with the way we perform click-away. Thanks!

Is there anything I can do to help?

@jbosse jbosse mentioned this pull request Oct 10, 2023
@jbosse
Copy link
Author

jbosse commented Oct 10, 2023

I need to close because I need the main branch in my fork for creating a new fix
Moving to #2856

@jbosse jbosse closed this Oct 10, 2023
@jbosse jbosse deleted the main branch October 10, 2023 17:13
chrismccord added a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phx-click-away should only trigger when the click was initiated outside the element
2 participants