Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring multiple custom migration paths #156

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Support configuring multiple custom migration paths #156

merged 2 commits into from
Jul 21, 2022
+134 −46

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Jul 21, 2022

@dvic
Support configuring multiple custom migration paths

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
54eb35a
@dvic
Copy link
Contributor Author

dvic commented Jul 21, 2022

@josevalim I did not deprecate get_migrations_function because now that I read the code again I think this was not an option that was part of the public api (it was not documented). I refactored the code a bit and introduced two new options that are used in the tests: mock_default_migration_directory_fn and mock_migrations_fn. These are used to test the plug without having to depend on ecto_sql (as far as I understand).

@josevalim
Copy link
Member

@dvic mix format is failing, can you please take a look? If you formatted it in your machine on Elixir v1.13 and it still fails on CI, then you can bump CI to Elixir v1.13. :)

@dvic
Run mix format

Verified

This commit was signed with the committer’s verified signature.
wolfy1339
GPG key ID: 3C4AA5CF88ECB25C
Verified
Learn about vigilant mode
bb81596
@josevalim josevalim merged commit 2cf35cf into phoenixframework:master Jul 21, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@dvic dvic deleted the support-migration_paths branch September 6, 2022 11:26
@josevalim josevalim mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_migrations_function of Phoenix.Ecto.CheckRepoStatus is not used for running migrations
2 participants
@dvic @josevalim