Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: npm version output parsing to allow version hooks #232

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

mattanglin
Copy link
Contributor

@mattanglin mattanglin commented Dec 14, 2023

Type of Change

  • Feature / Bugfix

What does it do?

Currently this action takes the output from running npm version... to directly parse the new version number. This PR updates the way this output is parsed to get the version number from the last line of output so that any preversion/version/postversion hooks can be run without their output affecting the parsed version number.

Example output with postversion hook:

$ npm version patch
> postversion
> echo 'just running another script of sorts here...'

just running another script of sorts here...
v10.1.2

@phips28 phips28 merged commit c657f92 into phips28:master Feb 1, 2024
@phips28
Copy link
Owner

phips28 commented Feb 5, 2024

@mattanglin is this PR causing this: #237 (comment) ?
Can you check pls and maybe help to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants