Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce bootpartition to be different from rootpartition #76

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

pguyot
Copy link
Owner

@pguyot pguyot commented May 5, 2023

Avoid errors when rootpartition is set to 1 but bootpartition is not unset.

@pguyot
Copy link
Owner Author

pguyot commented May 5, 2023

Related to #75

@razr This will make your build fail until you add bootpartition option. Are you OK for this to be merged?

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@razr
Copy link
Contributor

razr commented May 5, 2023

thank you, I'm fine with it, maybe it is also possible to check whether base_image is from nvidia.com and adjust default values for the rootpartition and bootpartition accordingly? Then there will be no need to set them explicitly.

@pguyot pguyot merged commit 8b6c7c1 into main Aug 26, 2023
47 checks passed
@pguyot
Copy link
Owner Author

pguyot commented Aug 26, 2023

thank you, I'm fine with it, maybe it is also possible to check whether base_image is from nvidia.com and adjust default values for the rootpartition and bootpartition accordingly? Then there will be no need to set them explicitly.

We can make this in another change.

@pguyot pguyot deleted the w18/nvidia-orin branch August 26, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants