Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse buffers and reduce allocations in GSSInputStream #3251

Closed
vlsi opened this issue May 20, 2024 · 0 comments · Fixed by #3255
Closed

Reuse buffers and reduce allocations in GSSInputStream #3251

vlsi opened this issue May 20, 2024 · 0 comments · Fixed by #3255

Comments

@vlsi
Copy link
Member

vlsi commented May 20, 2024

Describe the issue

Currently, GSSInputStream makes a number of allocations for every read call.

In fact, we know backend never produces messages that exceed 16KiB, so we could use 16KiB buffer in case of GSS connection, and GSSInputStream could peek into VisibleBufferedInputStream's buffer.

The following allocations could be removed:

davecramer added a commit to davecramer/pgjdbc that referenced this issue May 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
davecramer added a commit that referenced this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant