Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SslStores & Spark::secure support for a specific keystore alias #506

Closed
jforge opened this issue Mar 31, 2016 · 0 comments · Fixed by open-korean-text/open-korean-text-api#15 · May be fixed by kabakan/JCollection#1
Closed

Comments

@jforge
Copy link

jforge commented Mar 31, 2016

Generally I work with more than one KeyPair in keystores, and for that it would be a good additional benefit to be able to select a KeyPair by its alias name in the #secure call (otherwise just the first valid KeyPair would selected from the given keystore).

The SslStores class + the #secure method in the Spark class could be improved concerning that.

AFAIK the JVM itself does not support this in the corresponding VM parameters (java.net.ssl. ...), so it's up to the application to handle KeyStores with multiple KeyPairs.

  • For example Jetty supports such an alias by a Property "certAlias" in its org.eclipse.jetty.util.ssl.SslContextFactory.
  • Other products use other name (certAlias, keyAlias, javax.net.ssl.keyStoreAlias) or rely on the first certificate in the KeyStore.

If this is acceptable for you, I could provide a pull request for an appropriate solution.

If not we can discuss this in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant