Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command to stop server not working. #802

Open
jensakejohansson opened this issue Mar 1, 2022 · 2 comments
Open

CLI command to stop server not working. #802

jensakejohansson opened this issue Mar 1, 2022 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@jensakejohansson
Copy link

jensakejohansson commented Mar 1, 2022

Using version: @percy/cli 1.0.0-beta.76

I works fine to start the server with "npx percy exec:start" and send snapshots. However, I cannot stop the server. I've been trying: "npx percy exec:stop", but it just hangs, no response and the server keeps running. I have to use "Control+C" to terminate the process!

I do not want to use "npx percy exec:start --" since it does not suite my needs. I need to be able to start & stop the server seperate from starting test execution.

Running on Windows 10 in Command Prompt.

Also tried: http://localhost:5338/percy/stop and get success: true, but server does not stop.

Thankful for any investigation/help regarding this...

@wwilsman wwilsman added the 🐛 bug Something isn't working label Mar 1, 2022
@wwilsman
Copy link
Contributor

wwilsman commented Mar 1, 2022

Hey @jensakejohansson! Looks like I'm able to reproduce this as well. Will start working on a fix for this shortly. Have you tried downgrading @percy/cli yet to see which version introduced this change?

In the meantime, I was able to stop the process myself with pkill -f percy

@itsjwala
Copy link
Contributor

@samarsault I think solving this issue, might fix some of our CI flakiness for windows as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants