Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support device-pixel-ratio for cli-snapshot #1178

Open
samarsault opened this issue Feb 1, 2023 · 0 comments
Open

Support device-pixel-ratio for cli-snapshot #1178

samarsault opened this issue Feb 1, 2023 · 0 comments
Labels
🐛 bug Something isn't working

Comments

@samarsault
Copy link
Contributor

samarsault commented Feb 1, 2023

The problem

Resources with higher pixel densities are not capture when using along with dom snapshot i.e. in case of cli-snapshot,

Environment

  • @percy/cli version: 1.18
  • Version of Percy SDK you’re using:
  • If needed, a build or snapshot ID:
  • OS version:
  • Type of shell command-line [interface]:

Details

If necessary, describe the problem you have been experiencing in more detail.

Code to reproduce issue

snapshot.yml

- name: DPR 
  url: https://mdn.github.io/learning-area/html/multimedia-and-embedding/responsive-images/srcset-resolutions.html
  widths: [475]
  discovery:
    device-pixel-ratio: 3
npx percy --verbose snapshot snapshot.yml
@samarsault samarsault changed the title device-pixel-ratio for cli-snapshot Support device-pixel-ratio for cli-snapshot Feb 1, 2023
@itsjwala itsjwala added the 🐛 bug Something isn't working label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants