Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Command Topics" links on npm README are broken #1152

Open
oshi97 opened this issue Dec 7, 2022 · 4 comments
Open

"Command Topics" links on npm README are broken #1152

oshi97 opened this issue Dec 7, 2022 · 4 comments
Labels
📝 documentation Improvements or additions to documentation ✨ enhancement New feature or request

Comments

@oshi97
Copy link

oshi97 commented Dec 7, 2022

For example "percy exec" leads to a Github 404
https://github.com/percy/cli/blob/HEAD/packages/cli/packages/cli-exec#readme

@itsjwala itsjwala added the 📝 documentation Improvements or additions to documentation label Dec 8, 2022
@itsjwala
Copy link
Contributor

itsjwala commented Dec 8, 2022

Thanks, @oshi97 for raising this, we'll have a look. Also please don't mind raising a PR if you'd want to :)

@github-actions

This comment was marked as duplicate.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Dec 27, 2022
@itsjwala itsjwala removed the 🍞 stale Closed due to inactivity label Jan 3, 2023
itsjwala added a commit that referenced this issue Jan 11, 2023
itsjwala added a commit that referenced this issue Jan 11, 2023
@itsjwala itsjwala linked a pull request Jan 11, 2023 that will close this issue
@itsjwala
Copy link
Contributor

  • simply changing readme to use absolute links will break Github README navigation.
    • Example - Clicking on percy exec or any other commands in packages/cli/README.md will Navigate us to master commit - which is not expected.
  • What we'd want to do is fix the NPM package link by changing our build system - here

@github-actions
Copy link

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label Jan 31, 2023
@itsjwala itsjwala added ✨ enhancement New feature or request and removed 🍞 stale Closed due to inactivity labels Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 documentation Improvements or additions to documentation ✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants