-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "group_membership_request" event #2813
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alechkos
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thank you
Tested on WWeb v2.2412.54
shirser121
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
neekaru
pushed a commit
to KDevRev/whatsapp-web.js
that referenced
this pull request
May 2, 2024
Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com>
aleborile
added a commit
to Condo-AI/whatsapp-web.js
that referenced
this pull request
Jun 14, 2024
* fix: logo link (pedroslopez#2994) * fix: logo link * fix: fix broken link in readme file --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Update Client.js (pedroslopez#2813) Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Add members settings (pedroslopez#2788) * Update GroupChat.js * Update index.d.ts * style: clarify method doc * refactor: add additional check * fix: provide valid error name --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Fix: delete lines that remove data from this._data (pedroslopez#2958) * feat: `vote_update` event (pedroslopez#2596) * Merge branch 'add-polls' into polls-ext * added listener to poll votes * added isUnvote property * added option for custom message secret * usage example updated * added logic for catching removed votes * usage example updated * fixed logic for poll vote events * temp usage example * No more `isCurrentState` * messageSecret converted to array Co-authored-by: tuyuribr <45042245+tuyuribr@users.noreply.github.com> * docs updated * we already have messageSecret in vote.parentMessage * PollVote.selectedOptions changed to be similar to pollOptions * docs fixed * window.injectToFunction clarifications * minor clarifications * fix: typo * style: fix broken link in readme file --------- Co-authored-by: tuyuribr <45042245+tuyuribr@users.noreply.github.com> * 1.23.1-alpha.6 * Expose chat `pinned` property (pedroslopez#2771) Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Make an NPM release via GitHub (pedroslopez#2942) * Update release.yml * Update publish * Update release.yml * Update publish * Update publish: publish new docs before new version release * Update publish * Update publish --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * 1.24.0 --------- Co-authored-by: dark <61346219+qzdark@users.noreply.github.com> Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> Co-authored-by: Bauguelson <143646733+Bauguelson@users.noreply.github.com> Co-authored-by: Gulg <65360617+GulgDev@users.noreply.github.com> Co-authored-by: Shir Serlui <70711723+shirser121@users.noreply.github.com> Co-authored-by: tuyuribr <45042245+tuyuribr@users.noreply.github.com> Co-authored-by: WWebJS Bot <hello@wwebjs.dev> Co-authored-by: Thomas <1688389+Rakambda@users.noreply.github.com> Co-authored-by: Rajeh Taher <rajeh@reforward.dev>
aleborile
added a commit
to Condo-AI/whatsapp-web.js
that referenced
this pull request
Jun 14, 2024
* fix: logo link (pedroslopez#2994) * fix: logo link * fix: fix broken link in readme file --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Update Client.js (pedroslopez#2813) Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Add members settings (pedroslopez#2788) * Update GroupChat.js * Update index.d.ts * style: clarify method doc * refactor: add additional check * fix: provide valid error name --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Fix: delete lines that remove data from this._data (pedroslopez#2958) * feat: `vote_update` event (pedroslopez#2596) * Merge branch 'add-polls' into polls-ext * added listener to poll votes * added isUnvote property * added option for custom message secret * usage example updated * added logic for catching removed votes * usage example updated * fixed logic for poll vote events * temp usage example * No more `isCurrentState` * messageSecret converted to array Co-authored-by: tuyuribr <45042245+tuyuribr@users.noreply.github.com> * docs updated * we already have messageSecret in vote.parentMessage * PollVote.selectedOptions changed to be similar to pollOptions * docs fixed * window.injectToFunction clarifications * minor clarifications * fix: typo * style: fix broken link in readme file --------- Co-authored-by: tuyuribr <45042245+tuyuribr@users.noreply.github.com> * 1.23.1-alpha.6 * Expose chat `pinned` property (pedroslopez#2771) Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * Make an NPM release via GitHub (pedroslopez#2942) * Update release.yml * Update publish * Update release.yml * Update publish * Update publish: publish new docs before new version release * Update publish * Update publish --------- Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> * 1.24.0 --------- Co-authored-by: dark <61346219+qzdark@users.noreply.github.com> Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com> Co-authored-by: Bauguelson <143646733+Bauguelson@users.noreply.github.com> Co-authored-by: Gulg <65360617+GulgDev@users.noreply.github.com> Co-authored-by: Shir Serlui <70711723+shirser121@users.noreply.github.com> Co-authored-by: tuyuribr <45042245+tuyuribr@users.noreply.github.com> Co-authored-by: WWebJS Bot <hello@wwebjs.dev> Co-authored-by: Thomas <1688389+Rakambda@users.noreply.github.com> Co-authored-by: Rajeh Taher <rajeh@reforward.dev>
longgtruong
pushed a commit
to OpenDeur/whatsapp-web.js
that referenced
this pull request
Jul 1, 2024
Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com>
longgtruong
pushed a commit
to OpenDeur/whatsapp
that referenced
this pull request
Jul 17, 2024
Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com>
1 task
augustos0204
pushed a commit
to augustos0204/whatsapp-web.js
that referenced
this pull request
Jul 20, 2024
Co-authored-by: alechkos <93551621+alechkos@users.noreply.github.com>
This was referenced Sep 8, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Fix "group_membership_request" event #2516
Description
After investigating, I noticed replace "created_membership_requests" to "membership_approval_request" in src/Client.js solve the issue.
Motivation and Context
No event when there are new incoming membership requests
I was not receiving events using the demo code in #2516
How Has This Been Tested
Types of account:
Environement:
Types of changes
Checklist