Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config-settings option for pdm install command #2636

Closed
amolenaar opened this issue Feb 16, 2024 · 3 comments · Fixed by #2688
Closed

Config-settings option for pdm install command #2636

amolenaar opened this issue Feb 16, 2024 · 3 comments · Fixed by #2688
Labels
⭐ enhancement Improvements for existing features

Comments

@amolenaar
Copy link

Is your feature/enhancement proposal related to a problem? Please describe.

pdm build takes optional config settings, which are passed to the backend.

pdm install does not have such a feature, although it would be useful to add options to (for example) meson-python, to create debug builds.

Describe the solution you'd like

It would be nice to have a --config-settings option for pdm install.

I'm not sure if this option should apply only to the project or to all installed dependencies.

@amolenaar amolenaar added the ⭐ enhancement Improvements for existing features label Feb 16, 2024
@elramen
Copy link
Contributor

elramen commented Feb 27, 2024

Hi @amolenaar! Could you provide an example of a package and relevant config setting, and what the expected result should be when running it with pdm install?

@frostming
Copy link
Collaborator

@elramen If you are interested in this feature, I need to remind you that we perform the build operation in several places(see PreparedCandidate.build()), for different packages. And for now I think it is okay to make a "global" config setting to be shared by all packages to be built. The main problem to be solved in the implementation is how to share that global config elegantly.

@amolenaar
Copy link
Author

Sweet! Thanks @frostming! I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants