Handle yield termination depending on context #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
previously approved these changes
Nov 28, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
============================================
- Coverage 84.81% 84.81% -0.01%
Complexity 3460 3460
============================================
Files 155 155
Lines 9419 9418 -1
============================================
- Hits 7989 7988 -1
Misses 1430 1430 ☔ View full report in Codecov by Sentry. |
kylekatarnls
force-pushed
the
fix/yield-assignment
branch
from
4331a94
to
f653780
Compare
|
Sorry @AJenbo review get dismissed because I fixed the "testYieldAssignment" in PHPDoc, no change in concrete code. |
AJenbo
approved these changes
Nov 28, 2023
renovate bot
added a commit
to line/line-bot-sdk-php
that referenced
this pull request
Dec 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [phpmd/phpmd](https://phpmd.org/) ([source](https://togithub.com/phpmd/phpmd)) | `2.14.1` -> `2.15.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>phpmd/phpmd (phpmd/phpmd)</summary> ### [`v2.15.0`](https://togithub.com/phpmd/phpmd/blob/HEAD/CHANGELOG#phpmd-2150-20231211) [Compare Source](https://togithub.com/phpmd/phpmd/compare/2.14.1...2.15.0) \======================== - Added [#​1036](https://togithub.com/phpmd/phpmd/issues/1036) \[CLI] Allow option and value separated with equal sign - Require pdepend/pdepend 2.16.1 - Support PHP 8.3 [pdepend/pdepend#699](https://togithub.com/pdepend/pdepend/issues/699) - Support Symfony 7 [pdepend/pdepend#692](https://togithub.com/pdepend/pdepend/issues/692) - Fixed [pdepend/pdepend#691](https://togithub.com/pdepend/pdepend/issues/691) Float parsing for number starting with 0. - Fixed [pdepend/pdepend#689](https://togithub.com/pdepend/pdepend/issues/689) Handle conversion to/detection of UTF-8 encoding using either mbstring PHP extension or the polyfill provided by Symfony - Fixed [pdepend/pdepend#687](https://togithub.com/pdepend/pdepend/issues/687) Parsing the correct comment for method doc-block (Allow correct SuppressWarnings annotation handling on PHPMD) ([phpmd/phpmd#914) - Fixed [pdepend/pdepend#694](https://togithub.com/pdepend/pdepend/issues/694) Handle yield termination depending on context ([phpmd/phpmd#804) - Fixed [#​1044](https://togithub.com/phpmd/phpmd/issues/1044) strict option on applyOnClassMethods - Documented [#​1041](https://togithub.com/phpmd/phpmd/issues/1041) Mention public key used for signing the Phars - Documented [#​1042](https://togithub.com/phpmd/phpmd/issues/1042) Document installation with PHIVE </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/line/line-bot-sdk-php). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue: Fix phpmd/phpmd#804
Breaking change: no
Related to 899be3e