Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: payload admin bar #3684

Merged
merged 22 commits into from
Mar 5, 2025
Merged

feat: payload admin bar #3684

merged 22 commits into from
Mar 5, 2025

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented Oct 16, 2023

Imports https://github.com/payloadcms/payload-admin-bar into the Payload monorepo. This package will now be regularly maintained directly alongside all Payload packages and now includes its own test suite.

A few changes minor have been made between v1.0.7 and latest:

  1. The package name has changed from payload-admin-bar to @payloadcms/admin-bar.

    - import { PayloadAdminBar } from 'payload-admin-bar'
    + import { PayloadAdminBar } from '@payloadcms/admin-bar'
  2. The collection prop has been renamed to collectionSlug

  3. The authCollection prop has been renamed to authCollectionSlug

Here's a screenshot of the admin bar in use within the Website Template:

Screenshot 2025-03-05 at 1 20 04 PM

Copy link
Member

@denolfe denolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan on supporting this plugin for 3.0?

If so, we need to get this building, and we can get it imported.

@jacobsfletch
Copy link
Member Author

This isn't a plugin, it's a standalone pkg. This is something we will want to continue to maintain. I'll see about updating this PR.

@denolfe denolfe added keep Prevents from being marked stale or auto-closed. v2 labels Dec 3, 2024
jacobsfletch and others added 4 commits March 2, 2025 20:31
Fixes #11. Update props to receive an `authCollection` slug when users aren't the default.

Note: no breaking changes as `authCollection` is set to "users" by default.
Fixes #12. The `react` and `react-dom` peer deps now support v19.
@jacobsfletch jacobsfletch changed the base branch from 2.x to main March 5, 2025 04:24
@jacobsfletch jacobsfletch changed the title chore: imports admin bar feat: imports admin bar Mar 5, 2025
@jacobsfletch jacobsfletch changed the title feat: imports admin bar feat: payload admin bar Mar 5, 2025
@jacobsfletch jacobsfletch requested a review from denolfe March 5, 2025 04:46
Copy link
Member

@denolfe denolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A screenshot in the PR description would be nice, as many likely have not seen this 👍

@denolfe
Copy link
Member

denolfe commented Mar 5, 2025

Looks like the normal build flow was somehow skipped. Should figure that out before merging.

@denolfe denolfe removed the v2 label Mar 5, 2025
@jacobsfletch jacobsfletch enabled auto-merge (squash) March 5, 2025 18:41
@jacobsfletch jacobsfletch merged commit 9724067 into main Mar 5, 2025
77 checks passed
@jacobsfletch jacobsfletch deleted the chore/admin-bar branch March 5, 2025 19:14
Copy link
Contributor

github-actions bot commented Mar 5, 2025

🚀 This is included in version v3.27.0

@ecosse3
Copy link

ecosse3 commented Mar 5, 2025

Thank you for merging it into core. Do you have plans to add support for multiple locales when using localized Payload with Next.js with next-intl package? Right now text is hardcoded in English.

jacobsfletch added a commit that referenced this pull request Mar 6, 2025
…11566)

The Payload Admin Bar is now maintained in core and released under the
`@payloadcms` scope thanks to #3684. All templates and examples that
rely on this package now install from here and have been migrated
accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Payload team keep Prevents from being marked stale or auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants