fix(ui): views rendered in drawers can update step nav #11548
Merged
+13
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
changed the title
|
🚀 This is included in version v3.27.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering views within a drawer outside of the edit view, i.e. from the list view, it updates the underlying step nav to the collection of the drawer. This is true for both document drawers and list drawers.
This is because the logic controlling this behavior relies on the current edit depth, which is only incremented within the edit view itself. Instead of doing this, we can conditionally run the setter functions based the presence of a drawer slug.
An alternative to this would be to subscribe to the
drawerDepthcontext but this would be less efficient, as this requires an unnecessary hook and subsequent rendering cycle.