Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name not defined in 3.0 #230

Closed
janpipek opened this issue Sep 5, 2023 · 1 comment · Fixed by #231
Closed

Name not defined in 3.0 #230

janpipek opened this issue Sep 5, 2023 · 1 comment · Fixed by #231

Comments

@janpipek
Copy link
Contributor

janpipek commented Sep 5, 2023

Hello, I am seeing this message:

File "[EDITED]/yaspin/core.py", line 175, in __call__
    return cast(Fn, inner)
NameError: name 'Fn' is not defined

It seems that cast requires the type to be defined outside the TYPE_CHECKING condition.
Should I post a fixing PR?

All the best,
Jan

Version 3.0, Python 3.9

janpipek added a commit to janpipek/yaspin that referenced this issue Sep 5, 2023
@pavdmyt
Copy link
Owner

pavdmyt commented Sep 5, 2023

@janpipek thanks for the fix! Will include this into the next yaspin release.

pavdmyt added a commit that referenced this issue Sep 5, 2023
pavdmyt added a commit that referenced this issue Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants