Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of error for recursive detection #168

Closed
ath0mas opened this issue Feb 14, 2021 · 1 comment · Fixed by #169
Closed

Warn instead of error for recursive detection #168

ath0mas opened this issue Feb 14, 2021 · 1 comment · Fixed by #169

Comments

@ath0mas
Copy link
Contributor

ath0mas commented Feb 14, 2021

As I am willing to update/fork rm-modules for the possible Out of memory I am facing too (hughsk/rm-modules#5), updating readdirp with version 3.5 and its "infinite loop" fix seems perfect,

3.5 (Oct 13, 2020) disallows recursive directory-based symlinks. Before, it could have entered infinite loop.

but Should it be possible to not destroy and exit on error in this case? like adding recursive to NORMAL_FLOW_ERRORS

In rm-modules case, the expected behavior would be to continue and process all but the problematic entry.

@paulmillr
Copy link
Owner

perhaps. pull request for the change would be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants