Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add LICENSE file #25

Merged
merged 1 commit into from
Apr 13, 2024
Merged

chore: add LICENSE file #25

merged 1 commit into from
Apr 13, 2024

Conversation

nolanlawson
Copy link
Contributor

@nolanlawson nolanlawson commented Apr 11, 2024 •
edited

I noticed you have the MIT license defined in package.json, but no LICENSE file:

parse5-tools/package.json

Line 26 in 3b99212

"license": "MIT",

I assume this was just an oversight? If so, here is a LICENSE file, if it works for you. 馃檪

43081j
43081j approved these changes Apr 13, 2024
View reviewed changes
Copy link
Collaborator

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a sensible change to me 馃憤 it was an oversight that we missed it in the first place

@43081j 43081j merged commit 951ea35 into parse5:main Apr 13, 2024
1 check passed
@nolanlawson
Copy link
Contributor Author

Thanks for the merge! If you don't mind, could you do a release with the new LICENSE file? 馃檱

@43081j
Copy link
Collaborator

43081j commented May 3, 2024

have published 0.5.0 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nolanlawson @43081j