Update Elixir requirement to 1.11+ #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
commented
Jul 28, 2023
| @@ -53,7 +53,16 @@ defmodule ExCoveralls.JsonTest do | |||
| Json.execute(@source_info) | |||
| end) =~ @stats_result | |||
|
|
|||
| assert(File.read!(report) =~ ~s({"source_files":[{"coverage":[0,1,null,null],"name":"test/fixtures/test.ex","source":"defmodule Test do\\n def test do\\n end\\nend\\n"}]})) | |||
| assert( | |||
There was a problem hiding this comment.
JSON key ordering is not guaranteed anymore in OTP 26, so just decoding it here (and below) does the trick
|
Thank you, and sorry being late to respond. I may be releasing this updates as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elixir versions before 1.11 don't even receive security updates anymore, so I think it's safe to move over to 1.11+. Let's see what this does to CI 馃槈