Fix lcov 2.0 source file handling #315
Conversation
Prior to 2.0 being released, `genhtml` was much better about handling source files from the following paths: * `test/support/some_helper.ex` * `lib/foo/bar.ex` But after 2.0 was released, when rendering with `genhtml` the paths would be mangled and look like the following: * `test/support/test/support/some_helper.ex` * `lib/foo/lib/foo/bar.ex` I have tried in vain with many permutations of `--prefix` when running `genhtml` but the ultimate fix that made all of this go away was using the absolute path for the source file (`SF`).
warmwaffles
force-pushed
the
fix-lcov-2.0-pathing-problems
branch
from
3633ecf
to
c6b4bd4
Compare
| @@ -53,18 +53,18 @@ defmodule ExCoveralls.LcovTest do | |||
| Lcov.execute(@source_info) | |||
| end) =~ @stats_result | |||
|
|
|||
| assert(File.read!(report) =~ ~s(TN:\nSF:test/fixtures/test.ex\nDA:1,0\nDA:2,1\nLF:2\nLH:1\nend_of_record\n)) | |||
| %{size: size} = File.stat! report | |||
| assert(size == @file_size) | |||
There was a problem hiding this comment.
I had to remove the file size assertion because with the absolute path being used, it would cause the file size to be different.
We already test the file size via the File.read! and matching it against the string.
|
Hopefully @parroty this is okay to merge upstream as it would be nice for me to stop having to manually shim in a find replace for |
|
Thanks! |
|
I think the issue resides somewhere in the |
|
Thanks for the comment 🙇 . (Before releasing the new version) I just wanted to confirm if it works on lcov 1.x too, as it's about the path expansion, correct? |
|
Correct, it's the path expansion/truncation being messed up. I have not checked this with lcov 1.0 as my distro and others have all bumped and upgraded as well. |
|
This is what it looks like on LCOV 2.0 before this patch
And after the patch is applied
Generated with MIX_ENV=test mix coveralls.lcov
genhtml \
--output-directory cover \
--show-navigation \
--no-function-coverage \
--no-branch-coverage \
--flat \
--quiet \
./cover/lcov.info |
|
Here's the patch with lcov 1.16 pardon my crappy coverage here... you can see why I need this 😄 |
|
Thanks for the detailed information 🙇 . I try to release the package later today. |
Prior to 2.0 being released,
genhtmlwas much better about handling source files from the following paths:test/support/some_helper.exlib/foo/bar.exBut after 2.0 was released, when rendering with
genhtmlthe paths would be mangled and look like the following:test/support/test/support/some_helper.exlib/foo/lib/foo/bar.exI have tried in vain with many permutations of
--prefixwhen runninggenhtmlbut the ultimate fix that made all of this go away was using the absolute path for the source file (SF).