Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove wasmi backend from sc-executor #13800

Merged
merged 45 commits into from May 23, 2023

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Apr 2, 2023

This pull request removes the wasmi backend. This means that the runtime can not be run with an interpreter anymore. Runtime execution will then exclusively wasmtime.

Closes #13496.


polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr

@yjhmelody
Copy link
Contributor Author

yjhmelody commented May 19, 2023

we need a cumulus companion please.

Ok, let me try. But I do not know how to use this branch for cumulus.

@michalkucharczyk
Copy link
Contributor

you need to put cumulus companion: into description

@bkchr
Copy link
Member

bkchr commented May 19, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 1b7375a

@bkchr
Copy link
Member

bkchr commented May 21, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkchr
Copy link
Member

bkchr commented May 21, 2023

bot merge

@paritytech-processbot
Copy link

Error: Github API says paritytech/cumulus#2599 is not mergeable

@yjhmelody
Copy link
Contributor Author

Hi @bkchr Need a retry to merge it.

@koute
Copy link
Contributor

koute commented May 23, 2023

@yjhmelody I retried the job but it still fails; looks like you have to update your companion.

@yjhmelody
Copy link
Contributor Author

@koute The companion should be merged firstly and then no need companion PR more. Because the companion PR in cumulus not really need to update substrate commits.

@koute
Copy link
Contributor

koute commented May 23, 2023

@koute The companion should be merged firstly and then no need companion PR more. Because the companion PR in cumulus not really need to update substrate commits.

Yeah, that works too. Let's do that.

@bkchr bkchr merged commit 4dd06e4 into paritytech:master May 23, 2023
44 checks passed
@bkchr
Copy link
Member

bkchr commented May 23, 2023

/tip small

@substrate-tip-bot
Copy link

@bkchr A small tip was successfully submitted for @yjhmelody (15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips tip

gpestana pushed a commit that referenced this pull request May 27, 2023
* refactor: use builder api for all executors

* improve a lot

* remove unused args

* cleanup deps

* fix inconsistency about heap alloc

* add `heap_pages` back to try-runtime

* fix

* chore: reduce duplicated code for sc-service-test

* cleanup code

* fmt

* improve test executor

* improve

* use #[deprecated]

* set runtime_cache_size: 4

* wip

* fix and improve

* remove sc-executor-wasmi deps

* clean up bench and tests

* delete "client/executor/wasmi"

* cleanup

* refactor builder

* fix

* fix bench

* fix tests

* fix warnings

* fix warnings

* fix

* fix

* remove wasmi and fix tests

* unused imports

* improve by suggestions

* Update client/cli/src/arg_enums.rs

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
Ank4n pushed a commit that referenced this pull request Jul 8, 2023
* refactor: use builder api for all executors

* improve a lot

* remove unused args

* cleanup deps

* fix inconsistency about heap alloc

* add `heap_pages` back to try-runtime

* fix

* chore: reduce duplicated code for sc-service-test

* cleanup code

* fmt

* improve test executor

* improve

* use #[deprecated]

* set runtime_cache_size: 4

* wip

* fix and improve

* remove sc-executor-wasmi deps

* clean up bench and tests

* delete "client/executor/wasmi"

* cleanup

* refactor builder

* fix

* fix bench

* fix tests

* fix warnings

* fix warnings

* fix

* fix

* remove wasmi and fix tests

* unused imports

* improve by suggestions

* Update client/cli/src/arg_enums.rs

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* refactor: use builder api for all executors

* improve a lot

* remove unused args

* cleanup deps

* fix inconsistency about heap alloc

* add `heap_pages` back to try-runtime

* fix

* chore: reduce duplicated code for sc-service-test

* cleanup code

* fmt

* improve test executor

* improve

* use #[deprecated]

* set runtime_cache_size: 4

* wip

* fix and improve

* remove sc-executor-wasmi deps

* clean up bench and tests

* delete "client/executor/wasmi"

* cleanup

* refactor builder

* fix

* fix bench

* fix tests

* fix warnings

* fix warnings

* fix

* fix

* remove wasmi and fix tests

* unused imports

* improve by suggestions

* Update client/cli/src/arg_enums.rs

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
@yjhmelody yjhmelody deleted the refactor-remove-wasmi branch September 30, 2023 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove wasmi as sc-executor backend
5 participants