Revert "fix(server): return err on WS handshake err (#1288)" #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Mar 20, 2024
jsdw
reviewed
Mar 21, 2024
| @@ -448,6 +440,14 @@ where | |||
| let rpc_service = rpc_middleware.service(rpc_service); | |||
|
|
|||
| let fut = async move { | |||
| let upgraded = match hyper::upgrade::on(req).await { | |||
There was a problem hiding this comment.
Yup ok, I have no idea why moving this up would break anything offhand!
There was a problem hiding this comment.
I forgot about https://github.com/hyperium/hyper/blob/master/examples/upgrades.rs#L56-#L72 so it adds up :)
Thus, the http request must be answered before the upgrade can make progress but not super obvious based on the documentation. However good to know why it didn't work :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1288 never worked and let's revert it.