Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): return err on WS handshake err #1288

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix(server): return err on WS handshake err #1288

merged 1 commit into from
Feb 12, 2024
+9 −9

Conversation

niklasad1
Copy link
Member

I noticed this when I was replying to an issue and ws::connect should only return when the WS handshake has been completed.

@niklasad1
fix(server): return err on WS handshake err

Verified

This commit was signed with the committer’s verified signature.
eddumelendez Eddú Meléndez Gonzales
SSH Key Fingerprint: 2gq90gS5ANw25iD9sCQjrJyMU7pPxCZntbob9YuAeE4
Verified
Learn about vigilant mode
410897b
@niklasad1 niklasad1 requested a review from a team as a code owner February 7, 2024 16:37
jsdw
jsdw approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense; only return when upgrade is done, whcih also allows us to return any error emitted by it!

@niklasad1 niklasad1 merged commit d9c4a5c into master Feb 12, 2024
@niklasad1 niklasad1 deleted the na-fix-low-level-api branch February 12, 2024 09:06
niklasad1 added a commit that referenced this pull request Mar 20, 2024
@niklasad1
Revert "fix(server): return err on WS handshake err (#1288)"

Verified

This commit was signed with the committer’s verified signature.
eddumelendez Eddú Meléndez Gonzales
SSH Key Fingerprint: 2gq90gS5ANw25iD9sCQjrJyMU7pPxCZntbob9YuAeE4
Verified
Learn about vigilant mode
28db627 
This reverts commit d9c4a5c.
@niklasad1 niklasad1 mentioned this pull request Mar 20, 2024
Merged
niklasad1 added a commit that referenced this pull request Mar 20, 2024
@niklasad1
Revert "fix(server): return err on WS handshake err (#1288)" (#1326)

Verified

This commit was signed with the committer’s verified signature.
eddumelendez Eddú Meléndez Gonzales
SSH Key Fingerprint: 2gq90gS5ANw25iD9sCQjrJyMU7pPxCZntbob9YuAeE4
Verified
Learn about vigilant mode
Loading
Loading status checks…
1d5b08f 
* Revert "fix(server): return err on WS handshake err (#1288)"

This reverts commit d9c4a5c.

* fix docs

* Update server/src/transport/ws.rs
niklasad1 added a commit that referenced this pull request Mar 20, 2024
@niklasad1
Revert "fix(server): return err on WS handshake err (#1288)" (#1326)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e62f69d 
* Revert "fix(server): return err on WS handshake err (#1288)"

This reverts commit d9c4a5c.

* fix docs

* Update server/src/transport/ws.rs
niklasad1 added a commit that referenced this pull request Mar 25, 2024
@niklasad1
Revert "fix(server): return err on WS handshake err (#1288)"

Verified

This commit was signed with the committer’s verified signature.
eddumelendez Eddú Meléndez Gonzales
SSH Key Fingerprint: 2gq90gS5ANw25iD9sCQjrJyMU7pPxCZntbob9YuAeE4
Verified
Learn about vigilant mode
de5c997 
This reverts commit d9c4a5c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdw jsdw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niklasad1 @jsdw