Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Default Generic Param to HttpClient #1099

Merged

Conversation

tadeohepperle
Copy link
Contributor

fixes #1096

Added Default Generic Param like so:

/// JSON-RPC HTTP Client that provides functionality to perform method calls and notifications.
#[derive(Debug, Clone)]
pub struct HttpClient<S = HttpBackend> {
	/// HTTP transport client.
	transport: HttpTransportClient<S>,
	/// Request timeout. Defaults to 60sec.
	request_timeout: Duration,
	/// Request ID manager.
	id_manager: Arc<RequestIdManager>,
}

@tadeohepperle tadeohepperle requested a review from a team as a code owner April 26, 2023 07:51
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@niklasad1 niklasad1 merged commit 3cb95de into master Apr 26, 2023
14 of 15 checks passed
@niklasad1 niklasad1 deleted the tadeo-hepperle-add-default-generic-for-http-client branch April 26, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http client: add default backend type
3 participants