Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: correct error msg in test_view_index #58181

Merged
merged 2 commits into from Apr 8, 2024

Conversation

natmokval
Copy link
Contributor

CI failed, the reason: AssertionError: Regex pattern did not match.

Replaced error msg 'Cannot change data-type for object array' with 'Cannot change data-type for array of references.'

@natmokval natmokval added the CI Continuous Integration label Apr 8, 2024
@@ -312,7 +312,7 @@ def test_cant_or_shouldnt_cast(self, dtype):

def test_view_index(self, simple_index):
index = simple_index
msg = "Cannot change data-type for object array"
msg = "Cannot change data-type for array of references."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to support both error messages probably as the error messages only changed on the dev build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I added the previous error message to the new one.

@natmokval natmokval marked this pull request as ready for review April 8, 2024 17:09
@mroeschke mroeschke modified the milestones: 3.0, 2.2.2 Apr 8, 2024
@mroeschke mroeschke merged commit f56cba9 into pandas-dev:main Apr 8, 2024
45 of 46 checks passed
@mroeschke
Copy link
Member

Thanks for the quick fix!

Copy link

lumberbot-app bot commented Apr 8, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f56cba900e9f035b54519a0aa7d027bef01fc50b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #58181: CI: correct error msg in `test_view_index`'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-58181-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #58181 on branch 2.2.x (CI: correct error msg in test_view_index)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member

@natmokval mind doing the backport?

@natmokval
Copy link
Contributor Author

@natmokval mind doing the backport?

sure, I'll do the backport

natmokval added a commit to natmokval/pandas that referenced this pull request Apr 8, 2024
mroeschke pushed a commit that referenced this pull request Apr 8, 2024
…w_index) (#58187)

Backport PR #58181: CI: correct error msg in `test_view_index`
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* correct error msg in test_view_index

* correct err msg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants