Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Fix nightlies not building #58138

Merged
merged 1 commit into from
Apr 3, 2024
Merged

BLD: Fix nightlies not building #58138

merged 1 commit into from
Apr 3, 2024

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added the Build Library building on various platforms label Apr 3, 2024
@lithomas1 lithomas1 added this to the 2.2.2 milestone Apr 3, 2024
@lithomas1
Copy link
Member Author

I forgot to delete the other build condition when removing the special build step for numpy 2.0 in my previous PR.

@mroeschke mroeschke merged commit a70ad6f into pandas-dev:main Apr 3, 2024
92 checks passed
@mroeschke
Copy link
Member

Thanks @lithomas1

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 3, 2024
@lithomas1 @meeseeksmachine
Backport PR pandas-dev#58138: BLD: Fix nightlies not building
85e8255
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 3, 2024
Merged
@lithomas1 lithomas1 deleted the wheel-condition branch April 3, 2024 19:30
lithomas1 added a commit that referenced this pull request Apr 3, 2024
@meeseeksmachine @lithomas1
Backport PR #58138 on branch 2.2.x (BLD: Fix nightlies not building) (#…
a947587 
…58140)

Backport PR #58138: BLD: Fix nightlies not building

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@lithomas1 @pmhatre1
BLD: Fix nightlies not building (pandas-dev#58138)
b2d86e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lithomas1 @mroeschke