Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Build wheels with numpy 2.0rc1 #58126

Merged
merged 2 commits into from Apr 3, 2024
Merged

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added the Build Library building on various platforms label Apr 2, 2024
@lithomas1 lithomas1 marked this pull request as ready for review April 2, 2024 23:40
@lithomas1 lithomas1 added this to the 2.2.2 milestone Apr 2, 2024
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2024-04-02T23:18:35.7725624Z Successfully installed Cython-3.0.10 meson-1.2.1 meson-python-0.13.1 numpy-2.0.0rc1 packaging-24.0 pyproject-metadata-0.7.1 tomli-2.0.1 versioneer-0.29 wheel-0.43.0

@mroeschke mroeschke merged commit 9cd5e55 into pandas-dev:main Apr 3, 2024
88 checks passed
@mroeschke
Copy link
Member

Thanks @lithomas1

Copy link

lumberbot-app bot commented Apr 3, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 9cd5e5546c36c54dc8c3fab3dc20b092f812362e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #58126: BLD: Build wheels with numpy 2.0rc1'
  1. Push to a named branch:
git push YOURFORK 2.2.x:auto-backport-of-pr-58126-on-2.2.x
  1. Create a PR against branch 2.2.x, I would have named this PR:

"Backport PR #58126 on branch 2.2.x (BLD: Build wheels with numpy 2.0rc1)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lithomas1 lithomas1 deleted the bld-np2 branch April 3, 2024 01:00
lithomas1 added a commit to lithomas1/pandas that referenced this pull request Apr 3, 2024
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* BLD: Build wheels with numpy 2.0rc1

* Update pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants