Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Build wheels using numpy 2.0rc1 #58087

Merged
merged 3 commits into from Apr 1, 2024
Merged

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Mar 30, 2024

@lithomas1 lithomas1 added the Build Library building on various platforms label Mar 30, 2024
@lithomas1 lithomas1 added this to the 2.2.2 milestone Mar 30, 2024
@lithomas1 lithomas1 marked this pull request as ready for review March 30, 2024 19:56
@mroeschke mroeschke merged commit 96ad671 into pandas-dev:main Apr 1, 2024
88 checks passed
@mroeschke
Copy link
Member

Thanks @lithomas1

@rgommers
Copy link
Contributor

rgommers commented Apr 1, 2024

@lithomas1 @mroeschke this doesn't look correct to me. I just checked one CI log and it shows this after the "before build" step (re-installs numpy 1.26.4):

     Successfully installed Cython-3.0.9 meson-1.2.1 meson-python-0.13.1 numpy-1.26.4 packaging-24.0 pyproject-metadata-0.7.1 tomli-2.0.1 versioneer-0.29 wheel-0.43.0
    Installing build dependencies: finished with status 'done'

This is due to build isolation. The [build-requires] section in pyproject.toml needs updating instead, it needs something like "numpy>=2.0.0rc1,<2.3", (or <3 if you prefer) EDIT: in release branches, and "numpy>=2.0.0rc1 in main. I recommend copying what SciPy does (except change 2.0.0b1 to 2.0.0rc1 now):
https://github.com/scipy/scipy/blob/2a8c4ca6edceba5daaac60bbd213a84e7c03c361/pyproject.toml#L28-L34

@lithomas1 lithomas1 deleted the np2-wheels branch April 1, 2024 19:28
diogomsmiranda pushed a commit to diogomsmiranda/pandas that referenced this pull request Apr 1, 2024
* BLD: Build wheels using numpy 2.0rc1

* move to pyproject.toml

* typo
@lithomas1
Copy link
Member Author

@lithomas1 @mroeschke this doesn't look correct to me. I just checked one CI log and it shows this after the "before build" step (re-installs numpy 1.26.4):

     Successfully installed Cython-3.0.9 meson-1.2.1 meson-python-0.13.1 numpy-1.26.4 packaging-24.0 pyproject-metadata-0.7.1 tomli-2.0.1 versioneer-0.29 wheel-0.43.0
    Installing build dependencies: finished with status 'done'

This is due to build isolation. The [build-requires] section in pyproject.toml needs updating instead, it needs something like "numpy>=2.0.0rc1,<2.3", (or <3 if you prefer) EDIT: in release branches, and "numpy>=2.0.0rc1 in main. I recommend copying what SciPy does (except change 2.0.0b1 to 2.0.0rc1 now): https://github.com/scipy/scipy/blob/2a8c4ca6edceba5daaac60bbd213a84e7c03c361/pyproject.toml#L28-L34

Nice catch, thanks!

I was thinking in my head that editable installations would be messed up by the build-requires, but that obviously uses -no-build-isolation 🤦 .

I'll put up another PR fixing this.

lithomas1 added a commit that referenced this pull request Apr 9, 2024
…rc1) (#58105)

Backport PR #58087: BLD: Build wheels using numpy 2.0rc1

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
* BLD: Build wheels using numpy 2.0rc1

* move to pyproject.toml

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INFO: Please pin your numpy < 2 if installing pandas via pip
3 participants