BUG: reset_index not preserving object dtype for string option #56160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Strings
mroeschke
reviewed
Nov 26, 2023
| @@ -163,6 +163,12 @@ def test_reset_index_inplace_and_drop_ignore_name(self): | |||
| expected = Series(range(2), name="old") | |||
| tm.assert_series_equal(ser, expected) | |||
|
|
|||
| def test_reset_index_drop_infer_string(self): | |||
| # GH#56160 | |||
| ser = Series(["a", "b", "c"], dtype=object) | |||
There was a problem hiding this comment.
This test doesn't need to involve the infer_string option?
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
thanks @phofl |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Dec 7, 2023
…s-dev#56160) * BUG: reset_index not preserving object dtype for string option * Fixup * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 5e0df27)
phofl
added a commit
that referenced
this pull request
Dec 7, 2023
…bject dtype for string option) (#56387)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.