Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet/Feather IO: disable PyExtensionType autoload #55894

Merged
merged 6 commits into from Nov 9, 2023

Conversation

jorisvandenbossche
Copy link
Member

Similar to apache/arrow#38608, but doing it on our side as well for people that use latest pandas with older pyarrow.
(using a similar approach as https://github.com/pitrou/pyarrow-hotfix, without adding a required dependency on that package)

@jorisvandenbossche jorisvandenbossche added the IO Parquet parquet, feather label Nov 9, 2023
@jorisvandenbossche jorisvandenbossche added this to the 2.1.3 milestone Nov 9, 2023
@lithomas1
Copy link
Member

Can you add a whatsnew?

@mroeschke mroeschke merged commit 851fea0 into pandas-dev:main Nov 9, 2023
40 checks passed
Copy link

lumberbot-app bot commented Nov 9, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 851fea0ea38985cd7d5e0a3b7a7a7539b5883307
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55894: Parquet/Feather IO: disable PyExtensionType autoload'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55894-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55894 on branch 2.1.x (Parquet/Feather IO: disable PyExtensionType autoload)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the pyarrow-patch branch November 9, 2023 21:25
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Nov 9, 2023
* Parquet/Feather IO: disable PyExtensionType autoload

* don't install hotfix for pyarrow >= 14.0.1

* move patching to extension type definitions

* expand error message

* fix compat for pyarrow not installed

* add whatsnew

(cherry picked from commit 851fea0)
@jorisvandenbossche
Copy link
Member Author

Manual backport -> #55900

lithomas1 pushed a commit that referenced this pull request Nov 9, 2023
…ype autoload (#55900)

Parquet/Feather IO: disable PyExtensionType autoload (#55894)

* Parquet/Feather IO: disable PyExtensionType autoload

* don't install hotfix for pyarrow >= 14.0.1

* move patching to extension type definitions

* expand error message

* fix compat for pyarrow not installed

* add whatsnew

(cherry picked from commit 851fea0)
@jorisvandenbossche jorisvandenbossche mentioned this pull request Nov 9, 2023
dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Nov 15, 2023
### What changes were proposed in this pull request?
Upgrade pandas from 2.1.2 to 2.1.3

### Why are the changes needed?
Fixed infinite recursion from operations that return a new object on some DataFrame subclasses ([GH 55763](pandas-dev/pandas#55763))
and Fix [read_parquet()](https://pandas.pydata.org/docs/reference/api/pandas.read_parquet.html#pandas.read_parquet) and [read_feather()](https://pandas.pydata.org/docs/reference/api/pandas.read_feather.html#pandas.read_feather) for [CVE-2023-47248](https://www.cve.org/CVERecord?id=CVE-2023-47248) ([GH 55894](pandas-dev/pandas#55894))

[Release notes for 2.1.3](https://pandas.pydata.org/docs/whatsnew/v2.1.3.html)

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #43822 from bjornjorgensen/pandas-2_1_3.

Authored-by: Bjørn Jørgensen <bjornjorgensen@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Parquet parquet, feather
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants