TST: Make read_csv tests pyarrow 13 compatable on 2.1.x #55855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
WillAyd
reviewed
Nov 7, 2023
| @@ -86,7 +86,9 @@ def test_read_csv_local(all_parsers, csv1): | |||
|
|
|||
| fname = prefix + str(os.path.abspath(csv1)) | |||
| result = parser.read_csv(fname, index_col=0, parse_dates=True) | |||
|
|
|||
| # TODO: make unit check more specific | |||
| if parser.engine == "pyarrow": | |||
There was a problem hiding this comment.
Shouldn't we have a pyarrow version compat instead of blanket doing this? I think we should just take whatever precision pyarrow provides?
There was a problem hiding this comment.
I think we should just take whatever precision pyarrow provides?
Yeah agreed. We have the same TODO comment on the main branch where ideally we should do a version compat check (IMO it's worth investing the change there as this is just to get the 2.1.x branch green again)
|
Since this PR is green going to merge to allow other backport PRs to signal green if possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.