Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: Use ipython run_cell instead of run_code; remove pytest-asyncio #55853

Merged
merged 1 commit into from Nov 7, 2023

Conversation

mroeschke
Copy link
Member

pytest-asyncio is used for a unit test that uses an ipython API run_code that is async. I think the equivalent functionality is tested via run_cell which is not async and therefore allows us to remove the dependency.

Additionally, it appears this plugin is causing our CI failures

pytest-dev/pytest-asyncio#655
https://github.com/pandas-dev/pandas/actions/runs/6775657564/job/18415436948

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Dependencies Required and optional dependencies labels Nov 6, 2023
@mroeschke mroeschke added this to the 2.1.3 milestone Nov 7, 2023
@mroeschke
Copy link
Member Author

This gets us closer to a green CI and pytest-asyncio IMO wasn't an important dependency so going to merge

@mroeschke mroeschke merged commit 31fde44 into pandas-dev:main Nov 7, 2023
43 of 44 checks passed
@mroeschke mroeschke deleted the ci/deps/rm/pytest_asyncio branch November 7, 2023 01:21
Copy link

lumberbot-app bot commented Nov 7, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 31fde44d6616a7e3c0f184d47ef74be8e3ca72cd
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55853: DEPS: Use ipython run_cell instead of run_code; remove pytest-asyncio'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55853-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55853 on branch 2.1.x (DEPS: Use ipython run_cell instead of run_code; remove pytest-asyncio)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

mroeschke added a commit to mroeschke/pandas that referenced this pull request Nov 7, 2023
mroeschke added a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant