New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: .rolling() returns incorrect values when ts index is not nano seconds #55173
Conversation
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
the df variable name fixed in the test
The test was parametrised, the rolling unit generalised and the version commit reverted :) |
Bumping off of 2.1.1. |
@lithomas1 This fix is also related to other subfunctions like |
Can you add a whatsnew note for 2.1.2? |
Gladly added :) |
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Data conversion removed Tests merged
@jorisvandenbossche I have modified the validation function based on your suggestion. Tests are merged and the previous conversion has been removed. Please check it out and let me know |
@jorisvandenbossche I was about to ask how is the merge on this fix going on? Anything that I can help with? |
Tests are failing
|
…s when ts index is not nano seconds
Thanks @hkhojasteh and @jorisvandenbossche |
unit='s'
#55026The bug is referred to and fixed inside the code. It needs to be generalised. @jorisvandenbossche we need to have the first feedback if we can generalise the data type with some utils or more generally. Done during the in-person sprint check.