Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Implement .dt.year for ArrowExtensionArray #52330

Merged
merged 1 commit into from
Apr 2, 2023
Merged

ENH: Implement .dt.year for ArrowExtensionArray #52330

merged 1 commit into from
Apr 2, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Timeseries Arrow pyarrow functionality labels Mar 31, 2023
@mroeschke mroeschke added this to the 2.0 milestone Mar 31, 2023
@alippai
Copy link
Contributor

alippai commented Mar 31, 2023 •
edited

Just noticed:

@property
    def _dt_date(self):
        return type(self)(self._pa_array.cast(pa.date64()))

Shouldn't this be date32?

EDIT: Created #52332 instead to test it

@phofl phofl merged commit ac79adc into pandas-dev:main Apr 2, 2023
37 checks passed
@phofl
Copy link
Member

phofl commented Apr 2, 2023

Thx @mroeschke

@meeseeksmachine meeseeksmachine mentioned this pull request Apr 2, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 2, 2023
@mroeschke @meeseeksmachine
Backport PR pandas-dev#52330: ENH: Implement .dt.year for ArrowExtens…
ee2c84f 
…ionArray
phofl added a commit that referenced this pull request Apr 2, 2023
@meeseeksmachine @mroeschke @phofl
Backport PR #52330 on branch 2.0.x (ENH: Implement .dt.year for Arrow…
9bf45db 
…ExtensionArray) (#52359)

* Backport PR #52330: ENH: Implement .dt.year for ArrowExtensionArray

* Update array.py

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@mroeschke mroeschke deleted the arrow/dt/year branch April 2, 2023 18:07
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 6, 2023
@mroeschke @topper-123
ENH: Implement .dt.year for ArrowExtensionArray (pandas-dev#52330)
b307aaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Timeseries
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: AttributeError: 'ArrowTemporalProperties' object has no attribute 'year'
3 participants
@mroeschke @alippai @phofl