Cleanup philosophy doc #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other ends of sentences (period/full stop, '.') are followed by two spaces - these are followed by one. Making these match. Note this has no impact on rendering, Markdown only creates a single rendered space after a '.' in either case.
All other lines in this paragraph have no trailing whitespace, remove this single trailing whitespace to match. Note that this has no impact on the rendering of the Markdown.
As with previous commit, but for the whole document. Found using the regex "\. ([^ ])" and replacing with ". $1". All other ends of sentences (period/full stop, '.') are followed by two spaces - these are followed by one. Making these match. Note this has no impact on rendering, Markdown only creates a single rendered space after a '.' in either case.
As with previous commit, but for the whole document. Found using the regex "\s$". All other lines have no trailing whitespace, remove these single trailing whitespaces to match. Note that this has no impact on the rendering of the Markdown.
Dr-Irv
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Thanks @EFord36
The "two spaces" after a period is because I learned to type by taking a typing class 45+ years ago on a typewriter, and back in those days, you always added two spaces after a period! So it's a very hard habit to break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #630 and reading docs/philosophy, I noticed a 'too' typo for 'to', which I thought I'd fix (in the first commit in the PR).
While making that change though, I noticed a couple of inconsistencies in the same paragraph:
I fixed these for the paragraph, but also the rest of the document (using the regex
\. ([^ ])for the whitespace after '.', and\s$for the trailing whitespace.