implement missing str methods
#377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casefold, removeprefix, removesuffix
Daverball
reviewed
Jun 2, 2023
| @@ -208,6 +214,10 @@ def format(self, *args: t.Any, **kwargs: t.Any) -> "Markup": | |||
| formatter = EscapeFormatter(self.escape) | |||
| return self.__class__(formatter.vformat(self, args, kwargs)) | |||
|
|
|||
| def format_map(self, map: t.Mapping[str, t.Any]) -> str: # type: ignore[override] | |||
There was a problem hiding this comment.
Shouldn't this return Markup? Although technically it would be even more correct to return typing_extensions.Self, since you're using self.__class__, but that's a refactor you would have to apply pretty much everywhere.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format_mapwas missing, meaning the format arguments would not be escaped when using it.casefold,removeprefix, andremovesuffixwere missing, meaning they'd returnstrinstead ofMarkup. Theremove...methods are only in Python >= 3.9.fixes #370