Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jinja_loader typehint #5389

Merged
merged 1 commit into from Feb 3, 2024
Merged

Fix jinja_loader typehint #5389

merged 1 commit into from Feb 3, 2024

Conversation

Siecje
Copy link
Contributor

@Siecje Siecje commented Jan 23, 2024

mypy is complaining about

from jinja2 import ChoiceLoader
jinja_loader = jinja2.ChoiceLoader([FileSystemLoader(

This changes the type hint for jinja_loader to be BaseLoader which is the parent class of ChoiceLoader and FileSystemLoader.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@Siecje Siecje mentioned this pull request Jan 26, 2024
Closed
@davidism davidism added this to the 3.0.2 milestone Feb 3, 2024
@davidism davidism changed the base branch from main to 3.0.x February 3, 2024 20:15
@davidism davidism merged commit 3435d2f into pallets:3.0.x Feb 3, 2024
13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

jinja_loader type bug
2 participants
@Siecje @davidism