chore: Upgrade to yarn berry #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericjeney
reviewed
Feb 7, 2024
|
i've actually used yarn zero install without git lfs for the most part - i think the dependencies in this repo shouldn't get that big |
|
According to https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored, the |
ericjeney
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Chatted with @styu, and we decided it's okay to go without Git LFS for this repo because we don't expect to change dependencies frequently and the Git LFS billing model gets weirdly dumb / is more complex than it's worth for this small repo.
According to https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored, the .yarn folder should be gitignored
@adidahiya I think she got it right for the zero install version 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to latest yarn, and using zero install as well